djoos-cookbooks / newrelic

Development repository for the newrelic cookbook
https://supermarket.chef.io/cookbooks/newrelic
MIT License
143 stars 247 forks source link

Fixed PHP Agent Distributed Tracing #391

Closed alexkokkinos closed 3 years ago

alexkokkinos commented 3 years ago

386 implemented the Distributed Tracing configuration to the PHP Agent. However, it missed a key bit of code in recipes/php_agent.rb that applies the attribute.

I've also changed the styling of the newrelic.ini.erb to match the rest of the attributes that produce a commented out value by default.

I tested this manually on my own resources. Distributed tracing successfully enables using this branch.

Resolves #390

eheydrick commented 3 years ago

Any chance this could get merged in?

djoos commented 3 years ago

Thanks @alexkokkinos for the PR! (and @eheydrick for the nudge)