search

djoos / EscapeWSSEAuthenticationBundle

Symfony bundle to implement WSSE authentication
http://symfony.com/doc/current/cookbook/security/custom_authentication_provider.html
137 stars 59 forks source link

Future token check option #28

Closed marcoleong closed 10 years ago

marcoleong commented 10 years ago

Add options to disable future token check.

See the diff with this https://github.com/marcoleong/EscapeWSSEAuthenticationBundle/commit/cbafc3eb7bb181c73afde369c790318bd53b0bd3?&w=1

CRLF to LF issue :(

marcoleong commented 10 years ago

This commit has CRLF to LF, please add parameter &w=1 to view the diff.

djoos commented 10 years ago

Hi @marcoleong,

what about the solution in issue/PR #30?

Thanks in advance for your feedback!

Kind regards, David

djoos commented 10 years ago

Hi @marcoleong,

we've decided to go for the solution suggested in PR #30 as it allows for more flexibility than just enabling/disabling the future token check. It allows implementing the WSSE Authentication Bundle with more leniency when overwriting the provider as well as completely getting rid of the check, depending on the requirements for the implementation...

Thanks for your contribution, have a great weekend!

Kind regards, David

marcoleong commented 10 years ago

@djoos NP, I also thinking the other one is more flexible. Probably can do time range check also ;) Anyway, thanks for reviewing my PR.