djoos / EscapeWSSEAuthenticationBundle

Symfony bundle to implement WSSE authentication
http://symfony.com/doc/current/cookbook/security/custom_authentication_provider.html
137 stars 59 forks source link

Tag a release #45

Closed ruudk closed 10 years ago

ruudk commented 10 years ago

Using semver.org

QuingKhaos commented 10 years ago

+1 too. Either v1.0.0 if you think your a stable enough, or begin with something like v0.1.0 if you think the codebase is not stable enough. But please do not begin with 2.3 or other symfony corresponding numbers...

QuingKhaos commented 10 years ago

And symfony/framework-bundle and stuff which is used, when the bundle is used should be under require and not under require-dev. And please use ~2.3, so we can use it with any new symfony version.

djoos commented 10 years ago

Hi guys,

historically we haven't been tagging releases as we've kept the 3 branches (2.0, 2.1, 2.2 and master=2.3 -for now-) "active" for development. All latest commits on each of these branches are meant to be stable, but without prefixing them separately with the Symfony2 version I wouldn't really see how to keep the tags sensible...

How would you suggest tagging the bundle exactly, given this set up?

Thanks in advance for your feedback! David

QuingKhaos commented 10 years ago

It meant to be stable, but only using dev-master for productive apps is a pain in the ass.

Simply read and follow semver.org and begin with 1.0.0 and set the symfony dependencies to ~2.3 which means symfony >=2.3.0,<3.0.0 [1]. Composer does the rest picking the right symfony version. Btw. with this month also Symfony 2.2 is end of life, so no need to support them anymore. Begin tagging, this is user friendly. Follow semver.org and use ~2.3, if there are no BC breaks with 2.4 and so on, see [2]. Especially as Symfony 2.4 exists since months and 2.5 will be released soon. It's a matter of flavor if one is using the LTS or not. In finished projects I'm using 2.3, but currently active development is based on the newest version, where I can easily update to the next LTS if finished :)

If there are some incompatibilities with the new versions, I'll help you, since I need this bundle in a current project with REST API. And it's not a shame to have suddenly a 1.0.10 version, because of some bugfix releases. Release early and release often is a good strategy.

Glad to see a 1.0.0 tag soon ;)

Btw. dont forget to put the symfony/framework-bundle and symfony/security-bundle dependencies under require and not require-dev because they are real dependencies when using this bundle.

[1] https://getcomposer.org/doc/01-basic-usage.md#next-significant-release-tilde-operator- [2] http://symfony.com/doc/current/contributing/code/bc.html

iklymenko commented 10 years ago

Hi @djoos, we are using your awesome bundle in OroCRM (http://www.orocrm.com) and we would like to use stable version or some version where would not be added significant changes which can break compatibility with our code. We use some features which are not exist in latest stable version 2.2, so we are also interested in tag for the latest version. You can name it f.e. 2.3.0-alpha, or 2.3.0-beta, which will not mean GA release but will make it possible for us to add dependency on fixed revision and do not worry about possible major changes in development branch. In other case we will have to fork your dev branch until it will be published as stable.

Thanks for understanding.

djoos commented 10 years ago

Hi @iklymenko,

thanks for your feedback!

I'm looking at getting this issue sorted within the next couple of weeks...

I'll keep you updated!

Kind regards, David

iklymenko commented 10 years ago

Thank you, David!

djoos commented 10 years ago

Hi guys,

I've just released version 1.0.0 of the bundle.

@patkar: I've made sure to include the changes to composer.json to this first tagged/non-dev release.

FYI: I'll close this issue for now, but don't hesitate to get in touch if you have any further comments or remarks!

Kind regards, David

QuingKhaos commented 10 years ago

Wuhuuuuuu, thank you :grinning:

djoos commented 10 years ago

You're welcome, thanks for the discussion above!