search

djoos / EscapeWSSEAuthenticationBundle

Symfony bundle to implement WSSE authentication
http://symfony.com/doc/current/cookbook/security/custom_authentication_provider.html
137 stars 59 forks source link

Deprecation warnings are failing unit tests #66

Closed bkosborne closed 8 years ago

bkosborne commented 9 years ago

The deprecation warning in the Symfony security component is causing unit tests to fail.

I don't know the proper way to handle this. You cannot "fix" the problem by not using the SecurityContextInterface, because you then break compatibility with older Symfony versions.

You also cannot tell phpunit to NOT convert these to errors. If you look here, you can see that we'd have to turn off convertErrorsToExceptions completely to fix this problem. You can't just have phpunit ignore deprecation errors w/o also ignoring all the other errors.

Do you have any idea on how best to resolve this?

bkosborne commented 9 years ago

Also interesting is that it was 2.6 that actually deprecated the SecurityContext service, but they didn't add the warning code until 2.7.

2.7 is not released yet, but since this projects composer.json has "minimum-stability": "dev" it will pick up on 2.7-dev.

djoos commented 8 years ago

Merged - thanks!