search

djoos / EscapeWSSEAuthenticationBundle

Symfony bundle to implement WSSE authentication
http://symfony.com/doc/current/cookbook/security/custom_authentication_provider.html
137 stars 59 forks source link

Branches/symfony2.1 #8

Closed phiamo closed 12 years ago

phiamo commented 12 years ago

Hi i just updated my fork to be compat with symfony 2.1 no deps file needed anymore, composer does the work! Security Factory loading is done slightly different in symfony/master This should be considered as Answer to Issue #7

djoos commented 12 years ago

Hi Phiamo,

sorry for the late reply! Thanks for your contribution: we are looking into your pull request and will get back to you as soon as possible...

Have a great evening!

Kind regards, David

djoos commented 12 years ago

Hi Phiamo,

would it be possible to discuss some of the changes in the Pull Request?

The PR contains more than just the fixes required to support Symfony2.1... Is there any way you could separate that from the actual implementation of additional features (eg. extra parameter on Escape\WSSEAuthenticationBundle\Security\Authentication\Provider)

Also: is there any particular reason why you opted to add in "Wsse" to the AuthenticationProvider, Token, etc.? This has been an internal discussion when we originally built the WSSEAuthenticationBundle as well and we actually give preference to "Provider", "Token", etc. as there are currently no other Providers, Tokens, etc. classes in the same namespace.

Thanks in advance for your feedback!

Kind regards, David

djoos commented 12 years ago

Hi Phiamo,

I've contacted you about 15 days ago with some remarks on the PR. Please let me know your thoughts...

Kind regards, David

djoos commented 12 years ago

Hi Phiamo,

I'm closing this PR based upon the discussion above...

Don't hesitate to get in touch if you have any questions or comments!

Kind regards, David