search

djoos / EscapeWSSEAuthenticationBundle

Symfony bundle to implement WSSE authentication
http://symfony.com/doc/current/cookbook/security/custom_authentication_provider.html
137 stars 59 forks source link

fixed deprecated yaml #83

Closed data219 closed 8 years ago

data219 commented 8 years ago

Errors found after an upgrade of phpunit to latest version. Looks like latest phpunit incorporates latest symfony yaml parser, which in turn deprecated some features that where never compliant with the Yaml specs... Needed to wrap the references to services and params with quotes

emiliomg commented 8 years ago

What is the status of this PR?

skonsoft commented 8 years ago

I have the same problem. but the maintainer won't accept this PR.

djoos commented 8 years ago

Status was idle, now: merged... :-)

Thanks for your contribution! David

skonsoft commented 8 years ago

@djoos Thank you !! 👍 👍

i will delete the fork that i have created and reuse this one :)

djoos commented 8 years ago

Perfect - I'll ship a proper release at a later point!

emiliomg commented 8 years ago

Thank you, djoos! If you can manage, please tag a release in the near future so we can reference this point properly in our composer.json without having to use dev-master uglyness :)

djoos commented 8 years ago

Yeah, I'm currently at SymfonyLive London - but will try and push out a proper release over the weekend!

emiliomg commented 8 years ago

Thank you! Have fun @ SymfonyLive :)

djoos commented 8 years ago

Thanks - FYI: I've just pushed out version 2.2.2!

Kind regards, David

skonsoft commented 8 years ago

Thanks man ! 👍

emiliomg commented 8 years ago

Thank you! :-)