search

djoos / Symfony-coding-standard

Development repository for the Symfony coding standard
MIT License
401 stars 102 forks source link

Duplicate ScopeClosingBraceSniff #102

Open CarsonF opened 7 years ago

CarsonF commented 7 years ago

PSR2 imports Squiz.WhiteSpace.ScopeClosingBrace. Zend imports PEAR.WhiteSpace.ScopeClosingBrace.

It's hard to tell which one is better. I'm leaning towards keeping the one in PSR over Zend though.

wickedOne commented 7 years ago

thanks for your input @CarsonF !

there are more duplicates (ClassDeclaration.MissingBrace, ScopeClosingBrace.indent to name a few)

it's not that this blocks phpcs from running nor that either of them is raising false positives. in the end the violation needs to be fixed and after that both approve.

could you elaborate why we need to disable one of both?

CarsonF commented 7 years ago

Yes you are right. It just makes it a bit harder to sort through the list of errors in the report summary. I wouldn't have brought it up if it wasn't a simple one liner to disable the rule - I can PR if you want :smile:

wickedOne commented 7 years ago

yes, feel free to create a PR (personally i'd keep the PSR2 as well).