search

djoos / Symfony-coding-standard

Development repository for the Symfony coding standard
MIT License
402 stars 102 forks source link

Symfony.Commenting.FunctionComment.MissingParamTag should not complain if no params are documented and they are all typehinted #124

Closed stof closed 5 years ago

stof commented 6 years ago

If all arguments of the method are typehinted, duplicating the info in the phpdoc does not make sense. currently, the sniff requires either adding all @param or removing the phpdoc entirely. But this second option forces to remove the description too.

wickedOne commented 6 years ago

wouldn't this "break" ide info bubbles and phpdocumentor (i.e. not being completely useless)?

stof commented 6 years ago

IDEs are able to read PHP typehints since years (they are even able to generate this phpdoc for you when you have a requirement to keep it).

and phpdocumentor also supports using the native typehints AFAIK.

djoos commented 5 years ago

FYI: closing this one off - let's continue this issue in #120.