Infinity loop in ValidClassNameSniff

[yurahaid]

Hi If run sniffer for this code

<?php

interface BaseException {}

interface FooExceptionInterface extends BaseException {};

I get infinity loop.

In Symfony\Sniffs\NamingConventions\ValidClassNameSniff::116

$class = $phpcsFile->findPrevious(T_CLASS, $stackPtr); //findPrevious search T_CLASS but in this example we have interface and findPrevious returned false
$name = $phpcsFile->findNext(T_STRING, $class); // findNext expected $class  as int but this case - $class is bool 
//and in findNext method exist loop:
 for ($i = $start; $i < $end; $i++) 
//$i is false and if execute $i++ we get alway false and this loop is infinity

[wickedOne]

Define one class per file - this does not apply to private helper classes that are not intended to be instantiated from the outside and thus are not concerned by the PSR-0 and PSR-4 autoload standards; https://symfony.com/doc/current/contributing/code/standards.html#structure

does this also occur when you split them up in two seperate files?

[yurahaid]

Yes, if have file with only

<?php

interface FooExceptionInterface extends BaseException {};

this also occur.

[wickedOne]

i appear to be unable to reproduce your issue... could you perhaps specify which version phpcs and which version of this repo you're using?

[yurahaid]

PHP_CodeSniffer version 3.4.2 repo - 3.9.0

[yurahaid]

File for testing, but before run sniffer - change extension from txt to php InfinityLoopTest.txt

[yurahaid]

My command - vendor/bin/phpcs --standard=Symfony/ruleset.xml InfinityLoopTest.php my php version - v7.1.27

[wickedOne]

ok, bit of a weird edge case, but fixed @ https://github.com/djoos/Symfony-coding-standard/pull/172