djoos / Symfony-coding-standard

Development repository for the Symfony coding standard
MIT License
402 stars 102 forks source link

infinite loop fix #172

Closed wickedOne closed 5 years ago

wickedOne commented 5 years ago

fixes an infinite loop which would occur when an interface extends an improperly named interface ending with Exception as there's no T_EXCEPTION token and the only way to sniff the correct naming of an exception is to detect the classname when it's extending an exception.

nevertheless the incorrect naming of the extended class should raise an error in the extended class itself rather than in the class which is extending it

fixes #171

mmoll commented 5 years ago

@wickedOne Could you add a test?

wickedOne commented 5 years ago

no actually not. as described above, an error is thrown regardless...

nevertheless the incorrect naming of the extended class should raise an error in the extended class itself rather than in the class which is extending it.

mmoll commented 5 years ago

@wickedOne Next time I'll run the coverage report before asking for that, sorry for the noise :bowing_man:.

djoos commented 5 years ago

Thanks for your contribution @wickedOne and the review @mmoll!