Closed wickedOne closed 7 years ago
not sure how to fix the hhvm
issue @ travis...
Great work - I'll review this ASAP and will get back to you!
AFAIK PHP_CodeSniffer 3 is not the latest stable version, but still WIP. Should we keep this repo's master on PHP_CodeSniffer 2.x and create a 3.x branch, so when PHP_CodeSniffer 3.x goes stable, we can split up 2.x and 3.x (will then be the new master) for the standard?
Thanks in advance for your feedback!
according to their latest v3 tag it's stable and v2 will be in maintenance mode from now on so i think it's safe to make the 3.x the new master.
You're right - 2.x will go on serious bugs and security fixes only. 3.x will be the new master and I'll get a 2.x branch created.
Thanks!
as for the hhvm bug @ travis: we might want to consider dropping this test. as lined out in this blog post not only the hhvm team is slacking, but symfony will drop hhvm support as of v4
re: HHVM Let's not drop it completely for the time being - but let's allow for build failures on HHVM. I've just pushed that change to master; would you mind pulling .travis.yml from origin/master into your PR-branch?
Thanks in advance!
allowing failures for hhvm sounds fine to me! branch has been rebased & conflict resolved
Thanks @wickedOne, great work!
updated all sniffs from tag 2.10.1 so they are compatible with phpcs version 3 fixes #61
note:
due to the changed class names you won't be able to use the
--filter
construction like you used to do in your build.xml. and i've changed thebranch-alias
in thecomposer.json
file assuming you're going to tag this once it's merged