djoos / Symfony-coding-standard

Development repository for the Symfony coding standard
MIT License
402 stars 102 forks source link

phpcs 3.* #63

Closed wickedOne closed 7 years ago

wickedOne commented 7 years ago

updated all sniffs from tag 2.10.1 so they are compatible with phpcs version 3 fixes #61

note:

due to the changed class names you won't be able to use the --filter construction like you used to do in your build.xml. and i've changed the branch-alias in the composer.json file assuming you're going to tag this once it's merged

wickedOne commented 7 years ago

not sure how to fix the hhvm issue @ travis...

djoos commented 7 years ago

Great work - I'll review this ASAP and will get back to you!

djoos commented 7 years ago

AFAIK PHP_CodeSniffer 3 is not the latest stable version, but still WIP. Should we keep this repo's master on PHP_CodeSniffer 2.x and create a 3.x branch, so when PHP_CodeSniffer 3.x goes stable, we can split up 2.x and 3.x (will then be the new master) for the standard?

Thanks in advance for your feedback!

wickedOne commented 7 years ago

according to their latest v3 tag it's stable and v2 will be in maintenance mode from now on so i think it's safe to make the 3.x the new master.

djoos commented 7 years ago

You're right - 2.x will go on serious bugs and security fixes only. 3.x will be the new master and I'll get a 2.x branch created.

"There are no future planned releases for the 2.x branch, but there may still be additional 2.9.x versions released for a time due to the number of changes required to upgrade custom sniffs for 3.0. The intention is to limit 2.9.x releases to serious bug and security fixes only"

Thanks!

wickedOne commented 7 years ago

as for the hhvm bug @ travis: we might want to consider dropping this test. as lined out in this blog post not only the hhvm team is slacking, but symfony will drop hhvm support as of v4

djoos commented 7 years ago

re: HHVM Let's not drop it completely for the time being - but let's allow for build failures on HHVM. I've just pushed that change to master; would you mind pulling .travis.yml from origin/master into your PR-branch?

Thanks in advance!

wickedOne commented 7 years ago

allowing failures for hhvm sounds fine to me! branch has been rebased & conflict resolved

djoos commented 7 years ago

Thanks @wickedOne, great work!