search

djoos / Symfony-coding-standard

Development repository for the Symfony coding standard
MIT License
402 stars 102 forks source link

changing standard name from symfony2 to symfony? #65

Closed wickedOne closed 7 years ago

wickedOne commented 7 years ago

as i was working on the phpcs 3 compatibility issue i wondered whether it would be an idea to change the standard name from Symfony2 to Symfony as obviously this standard isn't bound to any version of symfony and might cause confusion in the foreseeable future as the release of Symfony 4 is scheduled for this year... (and basically a major each year thereafter)

any thoughts?

djoos commented 7 years ago

Great spot - definitely the way forward!

djoos commented 7 years ago

I'm keen on getting the 3.x PR merged in ASAP, as dev-master, and then we will worry about rewire the naming as part of additional refactoring, until we're happy and can push out 3.0.0.

What do you think?

wickedOne commented 7 years ago

yes i completely agree. it will also have effect on ruleset definitions (e.g. <rule ref="Symfony2.Commenting.ClassComment.SpacingBeforeTags">) so we might want to consider to add a little upgrade guide for those who use custom rulesets...

djoos commented 7 years ago

Agreed!

We do need to give this some proper thought, however: if we have to do this, the main version bump (3.x) is a great place to do it...

FYI: I'm off for a week, sorry if I don't get back immediately on issues/PRs - I'll pick things back up when I'm back!

wickedOne commented 7 years ago

yes let's do so! thanks for the heads up!