search

djorg83 / react-bootstrap-sweetalert

A React implementation of SweetAlert
https://djorg83.github.io/react-bootstrap-sweetalert/
MIT License
252 stars 55 forks source link

onConfirm not called when specifying show property #56

Closed wouter140 closed 5 years ago

wouter140 commented 5 years ago

I'm using the show property to show and hide the alert as this is the easiest for me as I also update the content and stuff. However, since the new version onConfirm does not seem to get called when specifying the show property and thus my alerts are never closing. I looked at the callstack and some debugging and it seems that because of the default closeanim activation https://github.com/djorg83/react-bootstrap-sweetalert/blob/8161f5d59e89be4c0a18133465fe6f4b97ee66a3/src/components/SweetAlert.tsx#L469 Should this not default to false as the default closeanim property is unset?

brunnomatheuus commented 5 years ago

+1

brunnomatheuus commented 5 years ago

And the buttons had style changes

djorg83 commented 5 years ago

Im looking into this right now

djorg83 commented 5 years ago

Fixed this with v5.1.6.

@brunnomatheuus what style changes are you referring to? The default button type for the cancel button, or the change to using flex positioning?