search

djoudi / Laravel-H5P

H5P Package for Laravel Framework
MIT License
22 stars 45 forks source link

Not working with latest h5p-php-library #22

Closed dailez closed 5 years ago

dailez commented 5 years ago

It seems that this library is not working with the latest h5p-php-library (1.22). Could you either freeze the h5p-library version or update the code (add the missing interface implementations)? Many thanks in advance

djoudi commented 5 years ago

solved

dailez commented 5 years ago

Unfortunately not yet working on my PC. Opening /create does not show the h5p editor. I use Laravel 5.8, PHP 7.1 and Windows. This is what I see:

Laravel-2019-07-23-07-07-65

On /h5p the menu on the top right is also now visible: See ...

Laravel-2019-07-23-07-07-30

Can you reproduce the error?

dailez commented 5 years ago

I think the problem of the startpage has to do with Bootstrap. Laravel 5.8 uses Bootstrap v4 and I think you are using v3.3.

lhestdave commented 5 years ago

Unfortunately not yet working on my PC. Opening /create does not show the h5p editor. I use Laravel 5.8, PHP 7.1 and Windows. This is what I see:

Laravel-2019-07-23-07-07-65

On /h5p the menu on the top right is also now visible: See ...

Laravel-2019-07-23-07-07-30

Can you reproduce the error?

populate the db and use the correct version of h5p-core/editor

djoudi commented 5 years ago

first you can upload library /library