search

djp952 / pvr.hdhomerundvr

Unofficial Kodi HDHomeRun DVR PVR Client
https://github.com/djp952/pvr.hdhomerundvr/wiki
Other
60 stars 9 forks source link

Kodi nightly 7/30/24 commits caused a compatibility issue with pvr.hdhomerundvr #130

Open ubernewy opened 1 month ago

ubernewy commented 1 month ago

It looks like some major changes to the PVR add-on API were introduced in the July 30th commits. Please take a look and if you are willing to make the necessary changes to support the latest nightly revision of Kodi it would be much appreciated.

https://github.com/xbmc/xbmc/commits/master?before=741f0604fddf1a33aca00c88f6d148f3723c62e9+315

djp952 commented 1 month ago

I'll have a look! Probably not too hard to bring the master branch up to match a new PVR API. More often than not it's a simple recompile against the updated API and changing some version codes :)

djp952 commented 1 month ago

What platform(s) do you need? A basic recompile with minor tweaks seems to work OK but there are clearly some new things that should be looked into. Quick look on Windows says it works decently well :)

ubernewy commented 1 month ago

Wow! Thank you so much for taking a look so quickly. Most of my devices use the Android Arm platform file. I would be very thankful if that one could be updated. I use your add-on extensively and would be happy to test whatever you need.

djp952 commented 1 month ago

No worries! I went ahead and did a full build for all platforms for ya :) This is a one-off so it won't auto-update or anything since I haven't set that up for Piers, but it should get you up and running for now!

Files: https://1drv.ms/f/s!AgEGEEVzGNq-jNtCRD4-DQnUJdLpsA?e=90xi1y

I'll be away for like 10 days starting tomorrow, but please leave this Issue open and report back for me? I definitely need to sit down and look more closely at the new API changes to see if we can do anything new or different.

ubernewy commented 1 month ago

I was able to try it with the Oct 11th nightly on a few of my android devices. It seems to work great for me. I have watched live tv, played recorded tv (with EDL commercial skips) and played radio channels. So far so good. I should be able to test it on other platforms next week. Thank you so much again for the updated builds I really appreciate it.

ubernewy commented 3 weeks ago

Looks like they bumped the min API to 9.2.0 now as of the 10/24/24 commits. If it's not too much of a hassle would you mind recompiling again please?

https://github.com/xbmc/xbmc/commit/e6129a0e9f6c236b40429f1a7bfc2c50d5729a10

[addons] PVR Add-on API version bump to 9.2.0 (incl. bump of min version).

define ADDON_INSTANCE_VERSION_PVR "9.2.0"

define ADDON_INSTANCE_VERSION_PVR_MIN "9.2.0"

djp952 commented 3 weeks ago

Oy, this one isn't trivial, but will work on it! The way Recordings work changed. Booo!

edit: check that, they made backwards compatible pretty simple. Overreacted. Building now, will post a link :)

djp952 commented 3 weeks ago

Sorry for the delay, here is version 22.9.4 which is compatible with the new v9.2 PVR API:

https://1drv.ms/f/s!AgEGEEVzGNq-jNwX0ir66Y2N_vyvTw?e=JiwEJM

They also bumped the filesystem API after the nightly I used (2024.11.03) so I backed that particular change out to make sure it works with what's out there.

Let me know if you run into anything, OK? Now there are even more things we can look into leveraging :) The API change to PVR Recordings seems to be mostly to be able to generate thumbnail images from the recording itself by allowing Kodi to open multiple streams against the recording. We should be able to do that, but I'm not sure how valuable that really is? I figure a lot of the time it will probably be for a commercial - lol.