search

djp952 / pvr.hdhomerundvr

Unofficial Kodi HDHomeRun DVR PVR Client
https://github.com/djp952/pvr.hdhomerundvr/wiki
Other
60 stars 9 forks source link

Leia PVR API 5.10.3 #44

Closed ssyspro closed 5 years ago

ssyspro commented 5 years ago

Please update Leia to pvr API 5.10.3

djp952 commented 5 years ago

There was a question here about the new build and coreelec? Anyway if you're watching for a reply the answer is that the Kodi version and PVR version have to match. Such is the difficulty with trying to support beta/rc versions of Kodi. The PVR API should be pretty much final at 5.10.3 now you can see if there is a newer build of coreelec (Leia Beta 5 or RC1) otherwise you can keep using the previous build of this PVR, there were no code changes (been crazy busy again sorry guys!). Let me know if you run into anything bad/weird I honestly just rebuilt and pushed out with almost zero testing this time :(

scottpinkston commented 5 years ago

It was coreelec based on beta 5. Odd because the pvr in the version looks different than what is in rc1.

<?xml version="1.0" encoding="UTF-8"?>
<addon id="kodi.binary.instance.pvr" version="5.10.4" provider-name="Team Kodi">
  <backwards-compatibility abi="5.10.4"/>
  <requires>
    <import addon="xbmc.core" version="0.1.0"/>
  </requires>
</addon>
djp952 commented 5 years ago

That is odd … the current maximum PVR version defined by Kodi is 5.10.3.

#define ADDON_INSTANCE_VERSION_PVR                    "5.10.3"
#define ADDON_INSTANCE_VERSION_PVR_MIN                "5.10.0"

Were you able to get things working?

scottpinkston commented 5 years ago

Yes, just reverted back a version of coreelec.

I think the 5.10.4 has to do with something they added for archives. I'll see what it looks like after they publish rc1. I know what to look for now. Thanks! Love what you have done for all of us.

On Thu, Nov 22, 2018, 23:31 Michael Brehm <notifications@github.com wrote:

That is odd … the current maximum PVR version defined by Kodi is 5.10.3.

define ADDON_INSTANCE_VERSION_PVR "5.10.3"

define ADDON_INSTANCE_VERSION_PVR_MIN "5.10.0"

Were you able to get things working?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/djp952/pvr.hdhomerundvr/issues/44#issuecomment-441158942, or mute the thread https://github.com/notifications/unsubscribe-auth/AeOkz3jeWPyt8MIxmKvUESO6d_kn3e-Aks5ux4gWgaJpZM4Yvbvn .

djp952 commented 5 years ago

No worries! Feel free to use these Issues for any questions/concerns in the future too! I try to respond reasonably quickly :)

edombroski commented 5 years ago

I apologize in advance if this is not the the appropriate place for this question, but I'm not sure I wanted to create a new issue for it...I understand the CoreELEC folks bumped the PVR API version to 5.10.4 on their own accord, and as such this plugin can't be loaded. Could you provide any guidance on hacking this to work on that platform? I'd be happy to get my hands dirty to try to hack this to work. Any advice appreciated. Thanks.

djp952 commented 5 years ago

No apologies necessary. I went ahead and opened a new issue (more like a statement, I guess) about it here for everyone: https://github.com/djp952/pvr.hdhomerundvr/issues/52.

I'll copy/paste your question about hacking it over there and respond!