djp952 / pvr.hdhomerundvr

Unofficial Kodi HDHomeRun DVR PVR Client
https://github.com/djp952/pvr.hdhomerundvr/wiki
Other
60 stars 9 forks source link

Extended Channel Names Not Displayed In Kodi (18.0 - RC3) #46

Closed gibxxi closed 5 years ago

gibxxi commented 5 years ago

Within the native HDHomeRun setup tool, the extended (real) proper-case channel names for scanned channels are displayed. Within Kodi (18.0 "Leia" - RC3) Only the truncated "Shortcut - All CAPS" channel names (abbreviations) are displayed.

My setup uses OTA guide data provision that's broadcast along with the channel data, and I'm based in the UK, using the Mendip Transmitter. I experience no such issues using any of the other HDHomeRun PVR add-ons available from the default Kodi Repo add-ons, but they don't provide recording functionality.

djp952 commented 5 years ago

Ugh, replying to myself again … one more thing I saw: I think you may need to return -1 from LengthLiveStream() if the stream is indeed realtime. Otherwise Kodi tries to seek to the end point. It could possibly explain the ridiculous PTS. I was reminded of this when hacking the recorded file in, reporting the actual length screwed everything up.

Maybe I should just write down what all the PVR functions return in my addon for live and recorded and let you decide if it's relevant - LMK.

I'll shut up now.

emveepee commented 5 years ago

Hi Michael, thanks for the input. The code for 3.13 isn't on line, I had it there on my own git but pulled it today so I could submit the PR tomorrow as one commit. The Timeshifting code is another dev's I use a new model.

Dan's file plays fine but the EPG tags shown during Live Radio don't match the EPG guide data. I would like to see your logs playing fake live tv with ffmpeg logging enabled.

The LengthLiveStream() returns the actual current length which seems to work fine for TV.

I will work a bit on the mime type tomorrow. I can stream mp3, aac and mp2, but not he-aac. Seeking is a problem. The probe function seem to work to determine the codec.

Martin

djp952 commented 5 years ago

Here you are: https://paste.kodi.tv/iwolohafaj.kodi

This is playing Dan's file as if it were "WETADT4" (PBS, Washington D.C.), with "realtime" hard-coded to return true and "length" hard-coded to return -1. Standard Debug logging and component-specific logging for ffmpeg are enabled.

Actions taken:

Hope it helps!

djp952 commented 5 years ago

Martin, did you see this: https://github.com/xbmc/xbmc/pull/15612 ? Claims to address DVB AAC issues with ffmpeg.

emveepee commented 5 years ago

Hope it helps!

Hey Michael thanks so it does have the big pts for the start. Are you saying the time and EPG data are showing correctly? You might need to tie it to a guide item with short programs.

The linked issue on the other post is not the same but the probe duration could be it, I will have a look.

Martin

emveepee commented 5 years ago

Hi again Michael I tried everything you mentioned and no luck In fact GetChannelStreamProperties() was never called likely because I set them in the channel setup. Recordings actually play OK except I am now have troubles keeping recording in progress files from stopping. .

Martin

emveepee commented 5 years ago

Hi Michael, hope you had a good week. I still am working away at PVR Radio with not a lot of luck. Regarding your PR I found why I don't need it was because all my stream end up here without it https://github.com/xbmc/xbmc/blob/master/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp#L570

djp952 commented 5 years ago

I did, thanks! Real work was in the way of fun work this week - lol.

I don't know why Kodi is behaving for you with m_startTime always set to zero, for me unless I also send in zero as the start time from GetStreamTimes() I ended up with all the nonsense values. I would have thought all streams with an actual non-zero start time would need to get m_startTime initialized by the call(s) to av_rescale() in IsVideoReady(), which is what my PR was supposed to help with. If I switch to always using zero, the problem does go away, but then Kodi thinks they are all recorded programs.

There are zero comments or reviews on the PR or the Issue, so I guess it's just a me thing. If it was important ksoo or the videplayer guy (FermetMenta? something like that) would have at least kicked it back as stupid by now.

I appreciate your time, and I apologize if I have wasted any of yours, I honestly thought I could help you but I don't think I was. At all. :(

gibxxi commented 5 years ago

FernetMenta.

More likely they've not even looked at it yet.

Dan / Gib.

djp952 commented 5 years ago

Perhaps! It's been a tough week, a little down right now.

Hey, since all the things that can be solved have been solved and we are tracking the audio stream issue via the other Issue, do you think we can close this particular one out? It's 108 posts long - lol. Very "TL;DR" for observers ...

gibxxi commented 5 years ago

I was going to suggest that very thing. You know how to get hold of me via other means if the need should arise.

Dan / Gib.

emveepee commented 5 years ago

Michael, I meant that for me that line of code does get executed for every start so m_startTime will be zeroed. I did just find an interesting thing changing URIUtils::IsUsingFastSwitch() by removing the IsPVR() reference solved all of my playback and many skipping problems in radio. You might want to see what it does for you.

Martin

djp952 commented 5 years ago

Will do Martin! Thank you sir! I'm actually moving forward with a separate enhancement for the immediate future (something less frustrating - ha) which will take me a few days or so. I truly appreciate your assistance here -- if we can get their attention I'm sure we can help Kodi get this stuff worked out.

Dan - you bet. I'm easy to find too :)

Martin - in case you ever want to hit me up directly, I'm at djp952@gmail.com. See you on the Kodi forums my friend! I'm going to check out NextPVR as well when the time frees up a bit, it's been many many years since I last tried it, it will be a lot of fun to see something else in action for a change!