remove asserts from release build for uwp

[jlenk]

Please consider this because there are asserts occurring on my release builds on XBox

[djp952]

Good catch! I only spot check the UWP packages on Windows 10, I never had any asserts come up. It actually needs to be done in 3 places in the project file - Win32, x64 and ARM. I'll take care of that right now - see if these builds solve the problem for you: https://1drv.ms/f/s!AgEGEEVzGNq-i9VxST3I8ByKi2zysA

commit with all three places changed: https://github.com/djp952/pvr.hdhomerundvr/commit/3e4f90701c535f1944709c63405f81a1d6f62117

I would like to know what assert(s) you got, they are in place to expose bad things happening. I'm guessing that it was either a zero-length recording or if version is prior to 1.3.13, the MPEG-TS 0x47 assert? (That one was removed in 1.3.13)

LMK if you're cool with the change and it solves the problem for you. This is my first PR, I actually read it via e-mail and thought it was an Issue, so I just fixed it.

[jlenk]

Thanks

No problem with the pull request. Those changes totally take care of the problem I am seeing.

The assert I’m seeing is from dvrstream.cc line 555 show below.

// Decode the current PCR using the 90KHz period only, there is // no need to deal with the full 27MHz period m_currentpts = decode_pcr90khz(current + 2U); if(m_startpts == 0) m_startpts = m_currentpts;

assert(m_currentpts >= m_startpts);

I have several files which reproduce this problem if needed.

-Jeff

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

---

From: Michael Brehm notifications@github.com Sent: Sunday, February 17, 2019 11:04:26 AM To: djp952/pvr.hdhomerundvr Cc: jlenk; Author Subject: Re: [djp952/pvr.hdhomerundvr] remove asserts from release build for uwp (#54)

Good catch! I only spot check the UWP packages on Windows 10, I never had any asserts come up. It actually needs to be done in 3 places in the project file - Win32, x64 and ARM. I'll take care of that right now - see if these builds solve the problem for you: https://1drv.ms/f/s!AgEGEEVzGNq-i9VxST3I8ByKi2zysA

commit with all three places changed: 3e4f907https://github.com/djp952/pvr.hdhomerundvr/commit/3e4f90701c535f1944709c63405f81a1d6f62117

I would like to know what assert(s) you got, they are in place to expose bad things happening. I'm guessing that it was either a zero-length recording or if version is prior to 1.3.13, the MPEG-TS 0x47 assert? (That one was removed in 1.3.13)

LMK if you're cool with the change and it solves the problem for you. This is my first PR, I actually read it via e-mail and thought it was an Issue, so I just fixed it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/djp952/pvr.hdhomerundvr/pull/54#issuecomment-464481794, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAOiORu6neF0Ffsy76F70WsFAFKMsKaoks5vOYuagaJpZM4a_olc.

[djp952]

I know you closed the PR, but I didn't give you the .appx files on that link, I updated the UWPs to the latest available nightlies and will publish "1.3.13a" for UWP formally within the next hour or so. 32-bit build is still "18.0-RC", but the 64-bit build is now "18.1-RC". I wish they would publish formal .APPX files.