search

djp952 / pvr.hdhomerundvr

Unofficial Kodi HDHomeRun DVR PVR Client
https://github.com/djp952/pvr.hdhomerundvr/wiki
Other
60 stars 9 forks source link

Bullet-proof null/missing SeriesIDs on epsiodes API queries #93

Closed djp952 closed 2 years ago

djp952 commented 2 years ago

This seems to have been a temporary problem caused by the TLS kerfuffle, but Nick at SiliconDust looked into the episodes API returning an HTTP 400 error. He found that the query had a missing SeriesID, so HTTP 400 was appropriate.

Add some code to ensure that a missing SeriesID will not be sent to the API, determine the root cause if that's actually still happening, and change the json_get_aggregate() SQLite extension method to allow for failure of individual queries and keep going rather than throwing an exception. Not sure how I might be able to communicate a "partial" aggregation, but we'll see.

djp952 commented 2 years ago

Related check to make ... it was pointed out that the "red dot" in the EPG isn't always showing up when it should, this would be impacted by a failure to get episode information. Go through all that logic and make sure it's not broken

djp952 commented 2 years ago

Missing SeriesID cannot happen in the addon. Nick at SiliconDust actually found a bum query from the HDHomeRun app I was running for comparison purposes. I let him know that the problem comes from their application.

Still want to give the red dot a once-over before calling this closed.

djp952 commented 2 years ago

No problems noted. Closing.