djpadbit / Sound-Physics

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
133 stars 19 forks source link

Sound without explicit location source is still affected #37

Open spiderpim opened 3 years ago

spiderpim commented 3 years ago

__I hope the issue is placed in the right version/fork of this mod

Sounds without a source are still affected by the Sound Physics mod. While not neccesarily a bug, it'd be nice if said sounds with no target or player as direct target gets ignored, just like noteblock sounds are now.

This includes the /playsound command used by command blockers and servers, aswell as forge's SoundEvent. Steps to replicate this issue:

  1. Execute a /playsound with no location (but with player as target)
  2. Go into a block/water or move from where the sound was originally
djpadbit commented 3 years ago

This is indeed the most up to date fork of Sound Physics (at least as far as i know). In versions 1.0.7+, noteblock sounds get affected by Sound Physics (although it's an option and you can turn it back off). So maybe you're using an older version (Here's the latest build). You can make the sound bypass Sound Physics by playing in category music, record or master(only in the latest builds) but if the sound is in mono it'll still be spatialized at the player's position, i can't really do much about that.