djpadbit / Sound-Physics

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
135 stars 19 forks source link

"Affect Note Blocks" Inneffective (1.12.2, 1.0.9) #41

Closed Valafi closed 4 years ago

Valafi commented 4 years ago

The volume of notes is scaled based on distance (and stuff) whether this option is on or off, which I'm guessing is a bug! (Maybe I misunderstand what the option is supposed to do?)

If you need more information, please let me know. I just tested with no mods except for Sound Physics and it's the same result. Am I missing something obvious? Using Forge 14.23.5.2847 (the last version before structure change, because I'm using the Technic Launcher).

djpadbit commented 4 years ago

What option specifically are you talking about ?

Valafi commented 4 years ago

Hi, it's the "Affect Note Blocks" option:

general {

If true, note blocks will be processed. [default: true]

B:"Affect Note Blocks"=false
djpadbit commented 4 years ago

The volume distance function changes are global (at least for all sounds that go through paulscode sound system). It's now rolloff rather than linear. This config option only changes if the note blocks are processed by Sound Physics itself. So if it's turned on, the note blocks will have reverb and be muffled when behind blocks otherwise they won't.

Valafi commented 4 years ago

Ah okay. Thank you very much for putting up with me knowing nothing about the sound system!