search

djpadbit / Sound-Physics

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
133 stars 19 forks source link

[Suggestion] Gliby's Voice Chat support? #46

Closed Cosmiiko closed 3 years ago

Cosmiiko commented 3 years ago

Hi! First of all thanks for the fork, works great on my server! I was wondering if it would be possible to make this work with Gliby's Voice Chat Reloaded (github)? Could you imagine you and your friends' voices having reverb in caves? Would be so great.

However on my side of things, having the Voice Chat mod installed seems to prevent this mod from working altogether... No reverb anywhere anymore... The reverb does work (on blocks, not voices) with another fork of the voice mod but the source code isn't available anymore...

djpadbit commented 3 years ago

The voice doesn't get affected by Sound Physics but i've fixed the no Sound Physics at all problem. Here's a build with the fix. I'm looking into making the voices affected.

Cosmiiko commented 3 years ago

Wow, thank you so much for the quick answer and work!

djpadbit commented 3 years ago

I added support for Sound Physics to Gliby's VC now. Here's a build with the new changes. (I also fixed the spelling because i wrote Gibly rather than Gliby)