search

djpadbit / Sound-Physics

A Minecraft mod that provides realistic sound attenuation, reverberation, and absorption through blocks.
GNU General Public License v3.0
135 stars 19 forks source link

There is no vehicle sound compatible with MrCrayfish's Vehicle Mod #52

Closed Kino0208 closed 3 years ago

Kino0208 commented 3 years ago

After installing Sound-Physics-1.12.2-1.0.10-1.jar, the vehicle in my MrCrayfish's Vehicle Mod-0.44.1-1.12.2 cannot emit engine sound normally! But my friend can hear the sound of my vehicle, I can't hear it myself! I'm sorry I don't speak English, I used machine translation of this paragraph (

在安装了Sound-Physics-1.12.2-1.0.10-1.jar之后，我的MrCrayfish's Vehicle Mod-0.44.1-1.12.2里的载具无法正常的发出引擎声！ 但是我的朋友可以听到我的载具声，我自己听不到！很抱歉我不会英语，这段话是我用机器翻译出来的（

djpadbit commented 3 years ago

I'm going to look into it

Kino0208 commented 3 years ago

我会调查一下

Thanks!

djpadbit commented 3 years ago

It should be fixed now, Here's a build with the changes. I'm sorry for the late reply though.

Kino0208 commented 3 years ago

它现在应该修复，这里是一个与更改的生成。不过， 我很抱歉回复太迟了。

It's ok! thank you very much! This is a surprise!

skedgywasedgy commented 3 years ago

This issue still exists in 1.16.3. I'd fix it myself but the code around where the fix was implemented is commented out in the 1.16.3 branch which gives the impression touching any of that will probably cause more problems.