djphazer / O_C-Phazerville

The kitchen sink of O_C firmware - do all the things!
213 stars 32 forks source link

Bug - Clock Skipper CV #68

Closed jamesdmorgan closed 3 weeks ago

jamesdmorgan commented 2 months ago

Noticed a problem with the cv input for Clock Skipper.

The documentation says it modulates the probability.

I found that it didn't do anything. I validated the CV input on other hemisphere apps and it works fine.

Unless i'm doing something completely wrong I think it doesn't work.

I'm on v1.7 (custom build via the GHA)

Cheers

James

djphazer commented 2 months ago

The input modulation probably works, but it looks like the UI just doesn't reflect the modulated value. I'll definitely fix that! Thanks for reporting this!

jamesdmorgan commented 2 months ago

Nice one. I ran it through Mordax data and didn’t see a change in gates but I may have given up

It definitely changes when I messed with the encoder.

Btw your additions have really enhanced O_c massively

Nice work

On Sat, 13 Apr 2024 at 18:50, Nicholas Michalek @.***> wrote:

The input modulation probably works, but it looks like the UI just doesn't reflect the modulated value. I'll definitely fix that! Thanks for reporting this!

— Reply to this email directly, view it on GitHub https://github.com/djphazer/O_C-Phazerville/issues/68#issuecomment-2053715037, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSNLZPB4YIIPL2BLEZ4NSDY5FV7TAVCNFSM6AAAAABGFPDGUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTG4YTKMBTG4 . You are receiving this because you authored the thread.Message ID: @.***>

djphazer commented 3 weeks ago

Fixed in v1.7.1