search

djphazer / O_C-Phazerville

The kitchen sink of O_C firmware - do all the things!
http://firmware.phazerville.com/
237 stars 35 forks source link

ADSREG decay stage skipped when sustain is lowest #88

Closed charonme closed 1 month ago

charonme commented 2 months ago

when sustain is the lowest only the attack part is generated - probably caused by this line in DecayAmplitude() that was there since hemisphere

djphazer commented 2 months ago

Good call! It looks like that line was supposed to be if (sustain == 255) so it will only skip the decay stage if sustain is maxed.

Just tested it out, seems good. Fix pushed - https://github.com/djphazer/O_C-Phazerville/commit/db2c9e10a8ecbfad7e90150bcf6074d695bb99df

djphazer commented 1 month ago

Fixed in v1.8