Release edit lock on refresh not working (Firefox)

[djplaner]

Doing a refresh on page isn't releasing the edit on lock in Firefox

• [x] When/how should it get called.
• [x] Why doesn't firefox do it?
• [x] Fix it

[djplaner]

How is it called

• onDestroy in CanvasCollections
• main.ts sets it up with addEventListener ('beforeunload' )

Turn of editing appears to be called.

Questions

Is the async nature thrown off by something that Firefox has problems with?

No. All the calls appear to be happening

Is it actually checking that deletion works

No. Appears it doesn't check the data - what is the data saying?

It should return

• null if 4040 or 401
• json from delete otherwise

It's the async thing - Firefox won't allow it

Solutions?

• keepalive - didn't work

Can we detect edit on and generate a dialog

Experiment -

1, generate a "are you sure" if edit on

2. if yes, can this be used to wait for callback to finish - update an element or some such?

Use beforeunload -- already are

Not working exactly - can detect it, but question is how to prevent default etc.

two questions

• Can it be done in onDestory
• How to do it via the $destory method

Design solution

• main still calls destroy - i.e. onDestroy
• onDestroy doesn't do anything asycnchronous
• checkBeforeUnload added to CanvasCollections
  • will start the async work and ask for user input before proceeding - advising they should turn editing off/save etc
  • if they accept it goes onto onDestory

[djplaner]

Too much warning

Even when edit is off and there are no changes, we're getting the popup - need to add something more

Tidy up the destroy