search

djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.93k stars 284 forks source link

Make CSDs optional/hidden by default #3

Closed cedws closed 3 years ago

cedws commented 4 years ago

Hi, just trying this out.

I've noticed that Wayland applications launched inside dwl have client side decorations. Sway disables these by default I think as they aren't really needed for tiling window managers.

031051-03-06-2020

djpohly commented 4 years ago

Glad to see you're giving it a try! I'm all for canning CSDs in dwl - looking at xdg_decoration_manager from wlroots, I hope it won't be too complicated. Interested in putting together a PR?

cedws commented 4 years ago

I'll have a look but I can't promise anything - sadly don't know much about Wayland protocols or wlroots. I need to read Drew DeVault's book at some point.

Ordoviz commented 4 years ago

For the moment you can disable the title bar in Firefox by navigating to Customize… in the menu and unchecking Title Bar.

cedws commented 4 years ago

@djpohly I see you made a commit for this :smiley: I was struggling anyway, so thanks. It doesn't appear to work yet, maybe it's still WIP. Comparing with cage's code, I think you need to call getxdecomode straight away in the createxdeco handler.

djpohly commented 4 years ago

Ah, yep, the protocol description seems to indicate that we have to send an xdg_toplevel_decoration.configure event right away. Fixing now - thanks!

The recent commit added support for xdg_decoration. Firefox, however, appears to support only the older KWin server_decoration protocol (which is considered obsolete by wlroots). I still hope to support it in dwl, but it might be trickier to get working right.

cedws commented 4 years ago

Firefox, however, appears to support only the older KWin server_decoration protocol (which is considered obsolete by wlroots)

That's kind of strange, unless the xdg_decoration protocol is relatively new. If sticking with the suckless theme then maybe implementing support for server_decoration isn't worth it - but that has obvious downsides.

djpohly commented 3 years ago

This is, I hope, fixed in commit 9071ce6. Could everyone test your variously decorated programs with the latest Git to see if client-side decorations still show up anywhere (and if they do, check sway as well)?

cedws commented 3 years ago

Sorry, would love to test it when I get time. You have probably validated it yourself too :+1: