search

djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.93k stars 285 forks source link

dwl does not allow xwayland clients to change override_redirect flag #432

Closed StratusFearMe21 closed 9 months ago

StratusFearMe21 commented 1 year ago

Info

dwl version: HEAD:wlroots-next (24a337e) wlroots version: HEAD (05dd08af)

Description

It appears that Xwayland is no longer able to reason whether a pop-up window is an actual window or not, and will focus/unfocus the window as if it were an actual window. This seems to cheese REAPER's logic somehow (at least that's what it looks like to me). This is a video of what's happening (with expanded boarder size to illustrate the problem), first I tried to access the context menu with normal mouse settings, then I tried it with mouse-follows-focus turned on

https://github.com/djpohly/dwl/assets/57533634/1b3d47e9-1a9e-4f5c-9ce7-3dd846e522b6

StratusFearMe21 commented 1 year ago

P.S, I was able to reproduce this on the main line (dwl HEAD:wlroots-next, wlroots HEAD) with all my mods and patches stripped

sevz17 commented 1 year ago

Where can I find the source code/binaries of the client?

StratusFearMe21 commented 1 year ago

For REAPER? You can find downloads on https://reaper.fm, or you can install the Arch package reaper

sevz17 commented 1 year ago

This is troublesome, seems like reaper creates popups with the override redirect flag turned off, and then turn it on.

Twinkie001 commented 1 year ago

I don't know it it's any help, but Sway doesn't seem to have any problems with the flag and it's also written in C... Reaper seems to work flawlessly on Sway, especially the git version. Maybe there could be some clues in their source code to solving this...?

StratusFearMe21 commented 1 year ago

REAPER also seems to work in Hyprland

Twinkie001 commented 1 year ago

Yeah, with a couple of window rules added... If stock in it makes plugins and sends disappear if you move the mouse away from the plugin popup.

Twinkie001 commented 1 year ago

Here is the Sway issue about this. Looks like they removed something from their xwayland.c file. https://github.com/swaywm/sway/issues/6324 There's a whole bunch of info in there, don't know if any of it applicable to dwl but maybe some basic wayland stuff can hold some clues to solving this.

sevz17 commented 9 months ago

@StratusFearMe21 @Twinkie001, reaper now works on the wlroots-branch (https://codeberg.org/dwl/dwl/src/branch/wlroots-next)

Twinkie001 thank you very much for trying to give solutions. :) StratusFearMe21 thanks for reporting.

StratusFearMe21 commented 9 months ago

@StratusFearMe21 @Twinkie001, reaper now works on the wlroots-branch (https://codeberg.org/dwl/dwl/src/branch/wlroots-next)

Twinkie001 thank you very much for trying to give solutions. :) StratusFearMe21 thanks for reporting.

Thank you! Can confirm that whatever you did worked!