search

djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.94k stars 283 forks source link

Refactor: separate drag icon from layers array and Lyr enum #443

Closed djpohly closed 1 year ago

djpohly commented 1 year ago

If we treat the drag icon as distinct from other layers (it doesn't have contents that are interactive, focusable, etc.), then we can iterate over layers meaningfully with a simple for loop.

ΔSLOC: -8

(I tried to make sure I caught everywhere that we were assuming the ZWLR_LAYER_SHELL constants were the same as our enum, but I wouldn't mind having that double-checked for safety.)

fauxmight commented 1 year ago

I cannot see any obvious misses. I have merged the no-drag-icon-layer branch and am running it without issue. Will report back here with any regressions noted.

sevz17 commented 1 year ago

Looks pretty good. Lets wait one or two days for @fauxmight to report regressions, In the meanwhile I'll be testing this too.

sevz17 commented 1 year ago

Thanks!