djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.93k stars 285 forks source link

tagcount should have been a #define #446

Closed bencollerson closed 1 year ago

bencollerson commented 1 year ago

Tagcount should have been set up as a #define rather than a const so it can be used to in array declarations etc.

sevz17 commented 1 year ago

I'm sorry for the late reply.

I don't feel like breaking user configuration again, just for external patches. I know, it's a trivial change, but still I don't think it should be made.

At most, I'm ok with adding a #define and defining the variable with the macro.

sevz17 commented 1 year ago

Thanks!

neuromagus commented 1 year ago

What I mean too. If u need variable in array length - this is only define, const int tagcount need a delete. "salt is salty".

sevz17 commented 1 year ago

Ah yeah, I didn't say it but I'm gonna revert the second commit, but I'll be when doing another change to the config