djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.93k stars 285 forks source link

Turning off and on monitor (using on monitor controller) makes floating all windows #472

Open mortezadadgar opened 1 year ago

mortezadadgar commented 1 year ago

Info

dwl version: dwl v0.4-45-g3c9742a-dirty wlroots version: wlroots-0.16.2-r1

Description

I don't think there is anything left to add to this bug report I tried to get stacktrace of dwl using ssh but it doesn't seem to be related Edit: doing the same using wlr-randr doesn't freezes the output

mortezadadgar commented 1 year ago

I was able to catch a stacktrace gdb.txt

sevz17 commented 1 year ago

Can you check #474?

mortezadadgar commented 1 year ago

@sevz17 it doesn't freeze or crash anymore though there's another bug that turns all tiling windows into floating after turning on the monitor

sevz17 commented 1 year ago

You are using just one monitor, right?

mortezadadgar commented 1 year ago

yes

sevz17 commented 1 year ago

Can you check again? but with the two lines I added below wlr_scene_node_reparent

mortezadadgar commented 1 year ago

moving two lines changes you made below wlr_scene_node_reparent made no difference

sevz17 commented 1 year ago

I see, I'm a bit busy rn. I'll check in more detail asap.

sevz17 commented 1 year ago

@mortezadadgar, can you try #474 again?

mortezadadgar commented 1 year ago

same

sevz17 commented 1 year ago

I merged #474, as you said it does not fix the problem about the floating windows (but it's better than a segfault). This remains open until I figure out how to solve the problem.

mortezadadgar commented 1 year ago

more observations on toggle monitor: