search

djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.93k stars 280 forks source link

Adding desktop file entry for QOL #484

Closed weiseguy1 closed 1 year ago

weiseguy1 commented 1 year ago

Updated the original makeDesktop patch

pm4rcin commented 1 year ago

@sevz17 I'm wondering if it couldn't be merged since it doesn't increase SLOC in dwl.c nor any header files and is just a few lines in Makefile. Also it just makes things easier if someone uses login manager since it's automatically discoverable. It doesn't alter the behaviour of dwl but it's just QOL improvement for people that need it.

sevz17 commented 1 year ago

@sevz17 I'm wondering if it couldn't be merged since it doesn't increase SLOC in dwl.c nor any header files and is just a few lines in Makefile. Also it just makes things easier if someone uses login manager since it's automatically discoverable. It doesn't alter the behaviour of dwl but it's just QOL improvement for people that need it.

Well, dwm doesn't include it so neither do we, but meh, let's do it.

Also do note that just like sway we don't support login managers (I know, it's not mentioned anywhere, I want add it and more documentation but I haven't had time)

weiseguy1 commented 1 year ago

Not gonna lie, this is pretty cool considering this is my first pull request to a major project!

pm4rcin commented 1 year ago

One last thing to do. Squash the commits into one and that's it from my perspective.

weiseguy1 commented 1 year ago

done

pm4rcin commented 1 year ago

Give that commit sensible name like Add desktop entry file or something similar. Also change the PR name since it's meaning has changed.

sevz17 commented 1 year ago

Please s/Added/Add/ in the commit message

sevz17 commented 1 year ago

Thank you!