djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.93k stars 284 forks source link

IPC patch doesn't work with latest main branch #490

Closed Xgames123 closed 10 months ago

Xgames123 commented 11 months ago

Info

dwl version: latest main wlroots version: 0.16.2

Description

I apply the ipc patch to the main branch using git. Then I fix the patch error by doing this

        wl_resource_set_implementation(resource, &dwl_manager_implementation, NULL, dwl_manager_destroy);

        for (i = 0; i < tagcount; i++) {
-               zdwl_manager_v1_send_tag(resource, tags[i]);
+               zdwl_manager_v1_send_tag(resource, "1");
        }

Then waybar gives this error:

dwl_status_manager_v2 not advertised
fauxmight commented 11 months ago

If the trouble is not specific to your individual setup, this one is an issue for the maintainer of the IPC patch.

I don't personally use the IPC patch and cannot offer much that way, but I know it is broadly used and you may also chat on the Discord channel with those who are using it regularly to see whether or not the problem is universal.

EDIT: There are multiple versions of the ipc patch on the wiki and only one appears to work with waybar. Have you verified that you are using the correct patch?

Xgames123 commented 11 months ago

Thanks for your response I asked on the discord How do I reach the ipc maintainer because the ipc patch is merged into the wiki

fauxmight commented 11 months ago

~The author's repository can be found on the dwl wiki page for the IPC patch.~

EDIT: My apologies. As @sevz17 notes below, the author has disabled issues in his repository. Other than discussion on Discord, making and maintaining a patch of your own on github (or elsewhere) or hoping someone else will take it over and do the same, I don't have a great suggestion here.

sevz17 commented 11 months ago

The author's repository can be found on the dwl wiki page for the IPC patch.

Although sometimes they disable issues for their repos...

fbushstone commented 11 months ago

I had to apply the patch manually. Unfortunately, I don't think you can just use patch -i and expect things to work.

PalanixYT commented 11 months ago

Although sometimes they disable issues for their repos...

It's the default behaviour on Github

sevz17 commented 11 months ago

Although sometimes they disable issues for their repos...

It's the default behaviour on Github

Really?, that's interesting... I guess the default behavior changed b/c I don't recall enabling them in my repo (or maybe I enabled them but don't remember).

Well, whatever. In any case you can comment on one of the commits they made.