djpohly / dwl

dwm for Wayland - ARCHIVE: development has moved to Codeberg
https://codeberg.org/dwl/dwl
Other
1.94k stars 283 forks source link

Support for unstable text_input and input_method Wayland protocols #6

Open Shugyousha opened 4 years ago

Shugyousha commented 4 years ago

These unstable protocols allow input methods (IMEs) to function without relying on some non-standardized method of communication (dbus etc).

Support for them has been added to Sway ( https://github.com/swaywm/sway/pull/4740 ) and in my opinion the functionality provided by those protocols is fundamental enough that they should be supported in dwl as well.

If you agree, I can start working on porting support for those two protocols from Sway to dwl (probably will take a while but I will try...).

djpohly commented 4 years ago

Sounds like something that should exist. If it would add a lot of code, I might prefer to have it as a dwm-style contributed patch rather than part of the default codebase, but either way I say go ahead.

Shugyousha commented 4 years ago

I have started working on it and it looks to be around 360 lines of code (including comments). It will still be a while until I am done (I only have time on weekends to work on this).

These protocols are still evolving as well so I expect that we will have to update the code once the new protocol versions are released. Releasing support for the current versions and then update the code once the new protocol versions are out is the right way to handle this in my opinion.