djrrb / Bungee

A chromatic signage typeface for vertical and horizontal setting.
https://djr.com/bungee
SIL Open Font License 1.1
336 stars 42 forks source link

Bungee Hairline: glyphs with no contours #113

Closed vv-monsalve closed 4 months ago

vv-monsalve commented 4 months ago

Hi @justvanrossum, the following glyphs do not have any contours at all. However, they have an AdvanceWidth of 1000 Please confirm this is intended. This was reported in #7795

🔥 FAIL Check if each glyph has the recommended amount of contours. 🔥 **FAIL**

The following glyphs have no contours even though they were expected to have some:

- Glyph name: whiteuppointingtriangle    Expected: 2

- Glyph name: whiterightpointingtriangle    Expected: 2

- Glyph name: whitedownpointingtriangle Expected: 2

- Glyph name: whiteleftpointingtriangle Expected: 2
[code: no-contour]
justvanrossum commented 4 months ago

I'm pretty sure this is intended, probably for layering. In any case, it matches the old fonts.

vv-monsalve commented 4 months ago

The previous Hairline font also had these glyphs empty. However, all the other fonts include outlines. I opened this issue to confirm if Hairline should also have them.

Perhaps this is more of a question for @djrrb, wdyt?

Screen Shot 2024-06-04 at 10 57 04 Screen Shot 2024-06-04 at 10 57 49 Screen Shot 2024-06-04 at 10 58 17
djrrb commented 4 months ago

Just is correct...the empty glyphs in Bungee Hairline was intentional, and intended for layering. These glyphs are too thin/complex to have anything going on inside them.

As Just says, this matches the old fonts and is not a regression, so I see no need for it to hold up a submission to GF.

I acknowledge that an empty character is not an ideal outcome if the Hairline is used on its own and not in layering. I’m not sure I have a better solution though...if we simply copy the outlines from Bungee Regular into Bungee Hairline, we would create a regression when the fonts are used in layering. And if we remove the glyphs from Bungee Hairline, not only would we create a regression in layering but we’d also cause the styles of Bungee to have inconsistent character coverage...which I’m guessing is a fontbakery fail?

I am open to your opinions on this, but my feeling is that it is okay to let this stand, since it only affects a small subset of characters, and is consistent with other unusual decisions in the Hairline font, such as the fact that the letters do not sit on the baseline.

Eventually, I would love to make a true Hairline weight for Bungee that is part of a conventional weight axis, which would not be constrained by the limitations of layering, and could contain proper hairline versions of these characters.

Below is a full list of glyphs that I believe are affected:

uni261A
uni261B
indexup
indexdown
indexupleft
indexupright
indexdownleft
indexdownright
uni261C
uni261D
uni261E
uni261F
indexdownleft.outline
indexdownright.outline
indexupleft.outline
indexupright.outline
uni261A.salt
uni261B.salt
indexdown.salt
indexdownleft.salt
indexdownright.salt
indexup.salt
indexupleft.salt
indexupright.salt
uni261C.salt
uni261D.salt
uni261E.salt
uni261F.salt
indexdownleft.salt_outline
indexdownright.salt_outline
indexupleft.salt_outline
indexupright.salt_outline
whiteuppointingtriangle
whitedownpointingtriangle
whiteleftpointingtriangle
whiterightpointingtriangle
vv-monsalve commented 4 months ago

I acknowledge that an empty character is not an ideal outcome if the Hairline is used on its own and not in layering.

This was the main concern in opening this issue and confirming these glyphs.

However, the reasoning behind the empty glyphs on this variant is now clearer, thank you!. There's no need to change the font, then. We'll continue with it as is now.

Eventually, I would love to make a true Hairline weight for Bungee that is part of a conventional weight axis, which would not be constrained by the limitations of layering, and could contain proper hairline versions of these characters.

This would be a great addition indeed!