djrrb / Bungee

A chromatic signage typeface for vertical and horizontal setting.
https://djr.com/bungee
SIL Open Font License 1.1
336 stars 42 forks source link

Vertical Kerning bug #42

Closed davelab6 closed 3 months ago

davelab6 commented 8 years ago

@behdad spotted a bug in the kerning; note in a TTX of Bungee-Regular.ttf how the coverage has one glyph in it, but ValueCount is zero:

        <SinglePos index="4" Format="2"> 
          <Coverage Format="1"> 
            <Glyph value="block.v"/> 
          </Coverage> 
          <ValueFormat value="0"/> 
          <!-- ValueCount=0 --> 
        </SinglePos> 

Removing the line <Glyph value="block.v"/> heals the font :)

djrrb commented 8 years ago

So the block.v glyph isn't touched by the {vkrn} feature, but it is touched by the respacing stylistic sets ss11 and ss12. My guess is that this offending block is generated by one of these features.

These are pretty specialized features so I'm not too worried about removing the offending pair.

ss11:
        pos block.v <140 0 280 0>;
ss12:
    pos block.v <0 -140 0 280>;

Are you able to tell which feature this offending block of code belongs to? I found it in the TTX but have no idea how to decipher it.

If not, maybe I can just remove them both and maybe not do too much damage. :-)

davelab6 commented 8 years ago

I'm not able :( It might be possible for Reed or others familiar with the FDK to tell....

djrrb commented 8 years ago

Ok I have these commented out. I'm leaving this open for now, just because I'm curious to dig deeper on this at some point.

justvanrossum commented 3 months ago

I can't find any evidence of this problem still persisting in the current release, so I'll close.