search

djrrb / Bungee

A chromatic signage typeface for vertical and horizontal setting.
https://djr.com/bungee
SIL Open Font License 1.1
330 stars 42 forks source link

fsType fix #92

Closed vv-monsalve closed 11 months ago

vv-monsalve commented 11 months ago

Hi @djrrb,

This PR changes the fsType value to 0 to set it as "installable embedding" following what was reported and discussed in this issue.

justvanrossum commented 11 months ago

This will also be fixed by #85, which isn't quite ready to merge.

I'm not sure it's even practically possible to build the sources from the main branch (it may be, but there is a reason #85 is being made), so perhaps, if an urgent fix is needed, we should consider hot fixing the fonts with TTX.

vv-monsalve commented 11 months ago

if an urgent fix is needed, we should consider hot fixing the fonts with TTX

Thanks, Just. In that case, waiting for the complete new version would be better.

Actually, when reviewing this, we discovered that the vertical metrics of the published fonts do not meet our specifications. There are significant differences between platforms, with Windows showing a huge line spacing.

I'll file a new issue with suggested values so that this revision can get included in that update effort.