Closed vv-monsalve closed 8 months ago
We'll implement this very soon, thanks for the suggested new values!
Excellent news! The values were calculated as an average between the current values for both Windows and Mac, and also to give a prudent space for stacked diacritics. Considering this is an all-caps display font, the leading has been kept tight while also making a compromise for the Vietnamese accents.
You can test the suggestions and make further tweaks if needed, as long as they fall within our recommended range of 120% to 130% for the leading :)
I'd be happy to stick to your recommendations.
The only thing I'm worried about is what fontbakery will say: there are a couple of "oversized" glyphs that go way over or under. I think the following are the most extreme: uni21AB.arrow
and uni21AC.arrow
:
The winAscent and winDescent values for the COLR fonts may be different than the suggestions, as they have a larger glyph set now than the released versions had.
The only thing I'm worried about is what fontbakery will say: there are a couple of "oversized" glyphs that go way over or under. I think the following are the most extreme: uni21AB.arrow and uni21AC.arrow:
Yes, I saw those oversized glyphs but prioritized the text and did not consider them in the VM calculations. Otherwise, the leading would end up being too loose for the text.
The winAscent and winDescent values for the COLR fonts may be different than the suggestions, as they have a larger glyph set now than the released versions had.
Sure!
The fonts currently published to Google Fonts don't follow the vertical metrics specifications, resulting in inconsistency across platforms, and appearing too wide on Windows.
In preparation for the new fonts update, they should follow the spec. However, due to the significant difference, we can't apply the strategy of inheriting the Win metrics, in which case, an overall regression must be accepted and a new compromise between platforms should be made.
Please find the current and proposed values below, with comparative images between them.
Current values
Requirements and new values proposed
Comparative images
Old = GF distributed / New = proposed values
Windows
Mac