djrrb / Bungee

A chromatic signage typeface for vertical and horizontal setting.
https://djr.com/bungee
SIL Open Font License 1.1
330 stars 42 forks source link

Vertical Metrics consistency #93

Closed vv-monsalve closed 8 months ago

vv-monsalve commented 10 months ago

The fonts currently published to Google Fonts don't follow the vertical metrics specifications, resulting in inconsistency across platforms, and appearing too wide on Windows.

In preparation for the new fonts update, they should follow the spec. However, due to the significant difference, we can't apply the strategy of inheriting the Win metrics, in which case, an overall regression must be accepted and a new compromise between platforms should be made.

Please find the current and proposed values below, with comparative images between them.

Current values

Metrics Bungee Hairline Inline Outline Shade Spice
sTypoAscender 860 860 860 860 860 860
sTypoDescender -140 -140 -140 -140 -140 -140
sTypoLinegap 200 200 200 200 200 200
hhea Ascender 860 860 860 860 860 860
hhea Descender -140 -140 -140 -140 -140 -140
hhea Linegap 200 200 200 200 200 200
winAscent 1634 1614 1634 1644 1634 1138
winDescent 914 894 914 924 914 362

Requirements and new values proposed

Metrics Bungee Hairline Inline Outline Shade Spice
sTypoAscender 1020 1020 1020 1020 1020 1020
sTypoDescender -300 -300 -300 -300 -300 -300
sTypoLinegap 0 0 0 0 0 0
hhea Ascender 1020 1020 1020 1020 1020 1020
hhea Descender -300 -300 -300 -300 -300 -300
hhea Linegap 0 0 0 0 0 0
winAscent 1634 1614 1634 1644 1634 1138
winDescent 914 894 914 924 914 362

Comparative images

Old = GF distributed / New = proposed values

Windows Win-before-after

Mac Mac-before-after

justvanrossum commented 8 months ago

We'll implement this very soon, thanks for the suggested new values!

vv-monsalve commented 8 months ago

Excellent news! The values were calculated as an average between the current values for both Windows and Mac, and also to give a prudent space for stacked diacritics. Considering this is an all-caps display font, the leading has been kept tight while also making a compromise for the Vietnamese accents.

You can test the suggestions and make further tweaks if needed, as long as they fall within our recommended range of 120% to 130% for the leading :)

justvanrossum commented 8 months ago

I'd be happy to stick to your recommendations.

The only thing I'm worried about is what fontbakery will say: there are a couple of "oversized" glyphs that go way over or under. I think the following are the most extreme: uni21AB.arrow and uni21AC.arrow:

image
justvanrossum commented 8 months ago

The winAscent and winDescent values for the COLR fonts may be different than the suggestions, as they have a larger glyph set now than the released versions had.

vv-monsalve commented 8 months ago

The only thing I'm worried about is what fontbakery will say: there are a couple of "oversized" glyphs that go way over or under. I think the following are the most extreme: uni21AB.arrow and uni21AC.arrow:

Yes, I saw those oversized glyphs but prioritized the text and did not consider them in the VM calculations. Otherwise, the leading would end up being too loose for the text.

The winAscent and winDescent values for the COLR fonts may be different than the suggestions, as they have a larger glyph set now than the released versions had.

Sure!