search

djsilva99 / heatrapy

Python library for simulating heat transfer processes
https://djsilva99.github.io/heatrapy
MIT License
72 stars 14 forks source link

[ Bugs ] Few simple and handy bugs #2

Closed MCilento93 closed 3 years ago

MCilento93 commented 4 years ago

Dear Mr. D.J. Silva,

I am using your package ‘heatrapy’ to do simple 1D Thermal model, and this thread to signal you few bugs. First and foremost, I would like to thank you for implementing it, because boost a fresh implementation of FD approach on python (I come from a different PL), and because it is very handy.

PS: below I would like to share some misprints I found working on your project.

  1. the name of the package maybe is wrong in the presentation page, top left figure here
  2. wrong instance variable attribute name, maybe contact rather than contacts (row 102 within def contactFilter(self,object)
  3. Borders is a tuple, in the example is a list (and written two times?)
  4. The description of single_object is maybe wrong for Q and Q0, the first entry value is the value of the flux per unit volume

Thank you for the comprehension,

Best regards,

djsilva99 commented 4 years ago

Thanks for reporting these bugs. I will fix them as soon as possible.

Best regards

djsilva99 commented 4 years ago

I fixed the four points.

Thanks