search

djspiewak / parseback

A Scala implementation of parsing with derivatives
http://parseback.io
Apache License 2.0
197 stars 22 forks source link

support for 2.13 #43

Closed SwiftEngineer closed 4 years ago

SwiftEngineer commented 4 years ago

Had some time on my hands and wanted to upgrade a personal project that uses this library a lot, so I thought I'd try my hand at solving #38 . At the very least I hope it can be used as a starting point for this project's maintainers.

~Full disclosure: I definitely still don't have a concrete understanding of how this project is being built. I'm also 70% sure that I only ran the JVM and scalaJS tests on 2.13. I would love to help make sure that this whole project is still gravy on 2.12 at least.~

Edit: Can always count on travis to show the way. I'm working on getting those tests passing now.

SwiftEngineer commented 4 years ago

Alright. That last commit at least got CI running again. Now it looks like 2.13 is failing due to some deprecations. I'll try and fix those before Monday.

djspiewak commented 4 years ago

Very very nice indeed! Thank you! I might know what's going on with the bincompat checks. I'll fiddle with it locally and merge.