search

djspiewak / sbt-github-packages

A simple sbt plugin for publishing to GitHub Packages, in the style of sbt-sonatype and sbt-bintray
Apache License 2.0
175 stars 27 forks source link

Add TokenSource.Property #43

Open iRevive opened 2 years ago

iRevive commented 2 years ago

The aim of the PR is to solve IntelliJ IDEA importing issue.

IDEA correctly picks up properties from .sbtopts file and therefore can download dependencies from the GitHub maven repository.

Partially solves #24, #26, and #42.

necosta commented 2 years ago

Hi @djspiewak , can we merge and publish this change?

Was debugging an issue with IntelliJ and was thinking the exact same solution as @iRevive suggests here.

Many thanks.

er1c commented 2 months ago

@iRevive I stole part of this idea for https://github.com/er1c/sbt-github/pull/2/files is that ok? it was interesting to work through some of the sbt tests, you have to nest a project/project/plugins.sbt to import the plugin, and then set the githubTokenSource in the project/plugins.sbt to override the resolver chain to resolve a github repo - publishing is more bespoke and easier

iRevive commented 2 months ago

@er1c no worries. I'm glad my changes are used for good :)