search

djspiewak / sbt-spiewak

A plugin which represents my personal SBT project baseline
Apache License 2.0
53 stars 20 forks source link

Pain after retagging an RC commit as a final #50

Open rossabaker opened 3 years ago

rossabaker commented 3 years ago

https://github.com/typelevel/fs2-grpc/runs/2316215041?check_suite_focus=true

  1. fs2-grpc-1.1.0-RC3 was tagged, released
  2. Retagged the same commit as 1.1.0
  3. Locally, version number is still inferred as 1.1.0-RC3. This seems like a git versioning pitfall.
  4. mimaPreviousVersions includes 1.1.0, even though it's greater than version 1.1.0-RC3
  5. Tweet embarrassingly that something is there that isn't

I guess we're not supposed to put multiple tags on one commit? But even if we do, I wouldn't expect to mima against newer versions.

djspiewak commented 3 years ago

Oh that's fun…

rossabaker commented 3 years ago

Locally, I might expect git versioning to get woozy in this scenario, but GitHub Actions knows the tag being built, and I'd hope that has precedence.