search

djspiewak / sbt-spiewak

A plugin which represents my personal SBT project baseline
Apache License 2.0
53 stars 20 forks source link

Can't add sbt-spiewak projects to the Scala 3 community build #83

Closed armanbilge closed 2 years ago

armanbilge commented 2 years ago

This is because the isDotty setting added to sbt-spiewak in https://github.com/djspiewak/sbt-spiewak/pull/54 conflicts with the one in the DottyPlugin used in the community build:

/__w/dotty/dotty/community-build/community-projects/http4s/build.sbt:1059: error: reference to isDotty is ambiguous;
it is imported twice in the same scope by
import _root_.sbtspiewak.SpiewakPlugin.autoImport._
and import _root_.dotty.tools.sbtplugin.DottyPlugin.autoImport._
    if (isDotty.value && githubIsWorkflowBuild.value)

Currently, all the projects in the CB using sbt-spiewak are using an old version of the plugin. But this means they cannot be updated.

I've asked in https://github.com/lampepfl/dotty/pull/14071#issuecomment-990564548 if the DottyPlugin is still needed since it was merged into sbt. However, is the isDotty setting still necessary for sbt-spiewak? According to https://github.com/sbt/sbt/issues/6080 isDotty has been renamed to isScala3 in sbt.

armanbilge commented 2 years ago

Hmm, seems isScala3 didn't make it into sbt after all based on https://github.com/sbt/sbt/issues/6080#issuecomment-757866207. So maybe we can rename isDotty in sbt-spiewak to isScala3.

armanbilge commented 2 years ago

They are removing sbt-dotty from the Community Build in https://github.com/lampepfl/dotty/pull/14395.