search

djsutherland / skl-groups

scikit-learn addon to operate on set/"group"-based features
BSD 3-Clause "New" or "Revised" License
41 stars 7 forks source link

might be a bug in transform #37

Open kayhan-batmanghelich opened 7 years ago

kayhan-batmanghelich commented 7 years ago

Hi Dougal,

I think, there might be a bug here in this line about the median trick:

https://github.com/dougalsutherland/skl-groups/blob/2584c10a413626c6d5f9078cdbf3dcc84e4e9a5b/skl_groups/kernels/transform.py#L197

I think scale = 1/median_ as you also mentioned in the help of the function. Your gamma is the inverse of the bandwidth (squared).

Besr