djtimca / haomnilogic

Hayward Omnilogic integration for Home Assistant available through HACS
Apache License 2.0
17 stars 6 forks source link

Invalid temperature readings making it through to HA #30

Closed lurgh closed 2 years ago

lurgh commented 2 years ago

In some circumstances, we are observing invalid values for sensor temperatures. For example, in this case my panel had been placed into Service Mode to override the pump schedule for 3 hours. This caused two spikes in air temp readings to 255F, one at the beginning and one at the end of the 3-hour run:

image

I have seen this before, maybe around updates or reboots, as well as readings dropping to zero. Got me to thinking that it might make sense to suppress improbable/impossible readings somewhere in the stack since missing points would be better at the app layer than wildly wrong values.

I can collect more data points if that would help, or maybe this is enough to go on.

djtimca commented 2 years ago

Fixed - release coming momentarily. Will now report unavailable if Hayward returns 255 degrees (invalid value).