search

djui / alias-tips

An oh-my-zsh plugin to help remembering those aliases you defined once
786 stars 50 forks source link

Simplify regex for shell_functions. #30

Closed jschaf closed 7 years ago

jschaf commented 7 years ago

Additionally, this prevents _alias_tips__preexec from getting called twice which saves about 100ms on startup. I'm not sure why it has this effect, but I suspect it has something to do with quoting and the dollar sign in the original regex.

Here's the zprof info from config before this commit:

Calls Total Each
Original 2 215.33 107.67
New 1 108.31 108.31
jschaf commented 7 years ago

I get the same number of matches with both regexps. I'm not sure why the original regex doesn't match underscores. I think you're probably okay without the underscores. It seems like an uncommon use-case to alias a private or internal functions. I'm happy to add the underscore if you want. Lemme know.

$ functions | grep '^[^'$'\t'' _-].\+ () {$' | wc -l
    314
$ functions | grep '^[a-zA-Z].\+ () {$' | wc -l
    314
$ functions | grep '^[a-zA-Z_].\+ () {$' | wc -l
    1352
djui commented 7 years ago

I think we can go ahead and stay aware, if later someone finds good reason.

djui commented 7 years ago

Thanks for your help! 🙇

pradyunsg commented 7 years ago

I would like an underscore. I heavily use underscores and feel it would be wrong to not support functions just because they have an underscore, regardless of whether or not it is at the start.

From the phone.

djui commented 7 years ago

Hi! underscores are still supported within the function's name, but currently just not as the first character.

Do you use functions with leading underscore?

pradyunsg commented 7 years ago

Nope I am good then.

On Sun, Nov 27, 2016, 21:01 Uwe Dauernheim notifications@github.com wrote:

Hi! underscores are still supported within the function's name, but currently just not as the first character.

Do you use functions with leading underscore?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/djui/alias-tips/pull/30#issuecomment-263128393, or mute the thread https://github.com/notifications/unsubscribe-auth/ADH7SUSrC8qdf6dHr3XjESmwIhXq9lgzks5rCaJJgaJpZM4K80QH .

djui commented 7 years ago

👍 great. Let me know when you see other reasons to bring back a more accurate implementation, and I will adjust it.