search

djui / alias-tips

An oh-my-zsh plugin to help remembering those aliases you defined once
781 stars 51 forks source link

Stop aborting the entire session #39

Closed orestisfl closed 7 years ago

orestisfl commented 7 years ago

Closes #37

I think this requires some tests. Perhaps from people with more complex configs. I don't know if SIGINTing zsh is a good practice. It could have some unwanted side effects.

pradyunsg commented 7 years ago

I don't know if SIGINTing zsh is a good practice.

I guess SIGTERM is a better way to do it? It's kinder than KILL but harsher than SIGINT...

I think this requires some tests.

Yes please. Having a test that ensures that the abort happens and that the entire shell doesn't die would be nice. ^.^

orestisfl commented 7 years ago

I am not really sure why SIGTERM is a better way. Why do we want it harsher? I think in any case you should accept the PR (or revert the previous changes) since it's an improvement from the current situation. This way, @graingert can use it and report if he is affected by any unwanted side effects.

pradyunsg commented 7 years ago

I think @djui should be the one doing that. :)

Sidenote: @djui Would you mind if I start merging PRs without taking your comments?

djui commented 7 years ago

@pradyunsg Please do!