search

djveremix / redis

Automatically exported from code.google.com/p/redis
0 stars 0 forks source link

redis-check-dump shows an overflowed value with huge .rdb. #300

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. make a huge dump.rdb file.
2. run redis-check-dump with that file.
3. I see an overflowed value in the result.

What is the expected output? What do you see instead?

I see below 

$ ls -la data/dump.rdb
-rw-rw-r--  1 dante dante 11853271020 Aug  5 15:24 data/dump.rdb
$ ./redis-check-dump data/dump.rdb 
==== Processed 9971202 valid opcodes (in -1031630877 bytes) ====================

instead of this:

$ ./redis-check-dump data/dump.rdb 
==== Processed 9971202 valid opcodes (in 11853271011 bytes) ====================

What version of the product are you using? On what operating system?

git HEAD version
on x86_64 Linux and Mac OS X Snow Leopard

Original issue reported on code.google.com by hatem...@gmail.com on 5 Aug 2010 at 11:48

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by anti...@gmail.com on 30 Aug 2010 at 9:47

GoogleCodeExporter commented 8 years ago 
I elaborated a bit on the diff you provided and "upgraded" more than only these 
types. The patch is located at: http://github.com/pietern/redis/tree/issue-300

Original comment by pcnoordh...@gmail.com on 31 Aug 2010 at 8:26

GoogleCodeExporter commented 8 years ago 
Merged! Thanks Pieter.

Can we close this?

Ciao,
Salvatore

Original comment by anti...@gmail.com on 31 Aug 2010 at 9:32

GoogleCodeExporter commented 8 years ago 
According to the issue status, QA should verify that the fix worked. But I 
guess we'll be OK ;-)

Original comment by pcnoordh...@gmail.com on 31 Aug 2010 at 9:35

GoogleCodeExporter commented 8 years ago 
QA found a bug! :)

If you try "make 32bit" you'll see interesting warnings

Salvatore

Original comment by anti...@gmail.com on 31 Aug 2010 at 9:39

GoogleCodeExporter commented 8 years ago 
Re-investigating.

Original comment by pcnoordh...@gmail.com on 31 Aug 2010 at 9:42

GoogleCodeExporter commented 8 years ago 
The new fix works for both platforms: 
http://github.com/pietern/redis/tree/issue-300

Original comment by pcnoordh...@gmail.com on 31 Aug 2010 at 11:08

GoogleCodeExporter commented 8 years ago 
Merged, thanks, closing the issue

Original comment by anti...@gmail.com on 31 Aug 2010 at 3:39