Heroku Deploy Feedback

[edherm]

Auth

• [ ] The session should persist on refresh
• [x] Disable Select Your Character and Create Your Characters links unless they are working features. Currently, they send me to the "Please Log In" page (though the Logout Demo User link is still displayed)
• [ ] Add login/signup! The demo user is nice, but you should complete Auth.

Adventures

• [ ] Seed a larger adventure with multiple options on some pages.
• [x] The save page button sits on the bottom of the page (no footer).

Dice Roller

• [x] Needs a label, not just < on the 'drawer'.
• [ ] Will the page eventually take the dice roll and compare it to any checks on the page (such as the downturn alley perception check)? Possibly disabling specific options from the current page or automatically navigating to a page?
• [x] On my Macbook with standard display settings, I can't see what the bottom die is without scaling your page. Can it be centered on your page?

[djwilki]

Auth

1) I thought Auth was optional! That's why I only made the bones for it, if I had to persist it, I would have skipped it entirely.

2) I will hide those buttons, I don't think I'll be getting to add characters this time around.

Adventures

1) Definitely will do

2) Footer is on the way!

Dice Roller

1) I'll put a rotated label then

2) That wasn't in scope at the moment, but eventually I could add buttons that allow you to make specific rolls, and depending on the outcomes, the links at the bottom for page navigation become available.

3) I need to change the scaling for the dice tray to vh, currently it is set to a pixel height, so I'll get on that.

[edherm]

In response to Auth #1: It is optional, but you should not do it halfway.

---

Ed Herman | Software Developer Personal Site https://edherm.github.io/ | LinkedIn https://www.linkedin.com/in/ed-herman/ | GitHub https://github.com/edherm | AngelList https://angel.co/ed-herman?public_profile=1 281-380-6025

On Thu, Oct 15, 2020 at 1:34 PM Daniel J Wilkins notifications@github.com wrote:

Auth

1.

I thought Auth was optional! That's why I only made the bones for it, if I had to persist it, I would have skipped it entirely. 2.

I will hide those buttons, I don't think I'll be getting to add characters this time around.

Adventures

1.

Definitely will do 2.

Footer is on the way!

Dice Roller

1.

I'll put a rotated label then 2.

That wasn't in scope at the moment, but eventually I could add buttons that allow you to make specific rolls, and depending on the outcomes, the links at the bottom for page navigation become available. 3.

I need to change the scaling for the dice tray to vh, currently it is set to a pixel height, so I'll get on that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/djwilki/BookOfAncientSecrets/issues/5#issuecomment-709479947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMYV4APSIMYDP4Y64ZC4KGDSK4XBJANCNFSM4SSGT7SQ .