search

djwooten / synergy

Python library for calculting synergy of drug combinations using several drug synergy frameworks
GNU General Public License v3.0
27 stars 5 forks source link

Wrong test #5

Closed thomasgaudelet closed 3 years ago

thomasgaudelet commented 3 years ago

Thanks for the package, it's very helpful. I think I have spotted an error though here

https://github.com/djwooten/synergy/blob/77e666c3b820bb1639105db221235d5af7e8e28b/src/synergy/combination/loewe.py#L71

I believe the test here should be: if self.variant.startswith("delta"): to be compatible with _deltasynergyfinder and _deltahsa

Cheers, Thomas

djwooten commented 3 years ago

Thanks for catching that, you are quite right. I have fixed this and pushed to v0.4.5, available on both github and pip.